test: Add end-to-end integration tests #447
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limbonaut
force-pushed
the
test/end-to-end
branch
from
3425836 to
092bc03
Compare
- Split "Has expected crash tags" test into separate level and mechanism tag tests - Remove redundant level assertion from "Has optional attributes" test - Add clarifying comment for shared test cases - Add level tag test to message capture tests - Fix comment grammar: "among" to "between"
Add common test cases to reduce duplication across test contexts. Extract shared assertions into parameterized test blocks that can be reused. Remove unused $TestType parameter from several test blocks. Configure dist attribute for integration tests.
Add comprehensive test suite for Godot runtime error handling, including stack trace validation and source context verification. Implement the corresponding CLI command to trigger and capture runtime errors with proper frame formatting.
previous session on macOS
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
limbonaut
commented
Nov 19, 2025
| objc::SentryThread *cocoa_thread = [[objc::SentryThread alloc] initWithThreadId:uint64_to_objc(thread_id)]; | ||
| cocoa_thread.stacktrace = stack_trace; | ||
| cocoa_thread.crashed = [NSNumber numberWithBool:NO]; | ||
| cocoa_thread.crashed = [NSNumber numberWithBool:YES]; |
Collaborator
Author
There was a problem hiding this comment.
Explanation: Aligning to how other platform implementations handle it. crashed attribute helps Sentry understand which thread caused the error.
Collaborator
Author
|
It's ready for review. However, it depends on: That one needs to be merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds end-to-end integration tests using app-runner submodule, and running on Linux, macOS and Windows.