-
-
Notifications
You must be signed in to change notification settings - Fork 12
chore: Refactor logging & avoid logger errors caused by SDK debug printing #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider some completely different name? Maybe something like "console" could work? Feel free to ignore if it sounds silly - just thinking out loud... :)
Yeah, I know. It's called Logging in Godot and console doesn't really fit either. In the end, I decide to call the Godot subsystem "logging" and the sentry part "structured logs". But it's the class names right? The base class for Godot's is UPDATE: |
Refactors engine logging in preparation for structured logs (#409).
This PR:
SentryLoggerto theloggingnamespace and renames it toSentryGodotLogger.SentrySDK.loggerinterface in the API, which will take over theSentryLoggerclass name.print.hto theloggingnamespace, as it belongs there.