Skip to content

build: Add missing crashpad_wer.dll to Windows build and export #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 30, 2025
Merged

build: Add missing crashpad_wer.dll to Windows build and export #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e571a6f
Copy crashpad_wer
limbonaut Sep 29, 2025
6cca178
Add crashpad_wer.dll to manifest
limbonaut Sep 29, 2025
d3da208
Dont use f string
limbonaut Sep 29, 2025
64389c2
Update CHANGELOG.md
limbonaut Sep 29, 2025
3551601
Add crashpad_wer.{dll,pdb} to command targets
limbonaut Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

- Fixed setting `throttle_window_ms` to 0 should disable it ([#382](https://github.com/getsentry/sentry-godot/pull/382))
- Fixed failing to set initial user on Apple platforms ([#390](https://github.com/getsentry/sentry-godot/pull/390))
- Added missing `crashpad_wer.dll` to Windows builds and export dependencies ([#396](https://github.com/getsentry/sentry-godot/pull/396))

### Other changes

Expand Down
14 changes: 12 additions & 2 deletions modules/sentry-native.SConscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,11 @@ elif platform == "macos":

# Crashpad handler
if platform == "windows":
build_targets.append(File(f"sentry-native/install/bin/crashpad_handler.exe"))
build_targets.append(File("sentry-native/install/bin/crashpad_handler.exe"))
build_targets.append(File("sentry-native/install/bin/crashpad_wer.dll"))
build_targets.append(File("sentry-native/install/bin/crashpad_wer.pdb"))
else:
build_targets.append(File(f"sentry-native/install/bin/crashpad_handler"))
build_targets.append(File("sentry-native/install/bin/crashpad_handler"))

# Other defines
env.Append(CPPDEFINES=["SENTRY_BUILD_STATIC", "SDK_NATIVE"])
Expand Down Expand Up @@ -199,6 +201,14 @@ def CopyCrashpadHandler(self, target_dir):
target_dir.File("crashpad_handler.pdb"),
source_dir.File("crashpad_handler.pdb")
)
copy_file_action(
target_dir.File("crashpad_wer.dll"),
source_dir.File("crashpad_wer.dll")
)
copy_file_action(
target_dir.File("crashpad_wer.pdb"),
source_dir.File("crashpad_wer.pdb")
)
else:
copy_file_action(
target_dir.File("crashpad_handler"),
Expand Down
6 changes: 4 additions & 2 deletions src/manifest.gdextension
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,13 @@ linux.x86_32 = {
}

windows.x86_64 = {
"res://addons/sentry/bin/windows/x86_64/crashpad_handler.exe" : ""
"res://addons/sentry/bin/windows/x86_64/crashpad_handler.exe" : "",
"res://addons/sentry/bin/windows/x86_64/crashpad_wer.dll": ""
}

windows.x86_32 = {
"res://addons/sentry/bin/windows/x86_32/crashpad_handler.exe" : ""
"res://addons/sentry/bin/windows/x86_32/crashpad_handler.exe" : "",
"res://addons/sentry/bin/windows/x86_32/crashpad_wer.dll": ""
}

macos.debug = {
Expand Down
Loading