fix: Correctly store last event id #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
reviewed
Dec 2, 2019
There was a problem hiding this comment.
@kamilogorek this works fine if there's no concurrency involved.
In particular, using the global sentry.LastEventID() only makes sense with no concurrency involved. Otherwise, what can we possibly tell about the return value!?
When LastEventID() returns EventID (string) instead of *EventID, user code gets simpler because it doesn't need a nil-check.
rhcarvalho
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
I know it requires a change in
Hubstruct andLastEventIDsignature, but this method was never implemented in the first place and we are still in0.xso I think it should be fine.