Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extract correct type and value from top-most error #85

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

kamilogorek
Copy link
Contributor

Fixes #70 cc @mfridman @fedoricobond

@kamilogorek kamilogorek merged commit 81a431c into master Nov 13, 2019
@kamilogorek kamilogorek deleted the causer-type branch November 13, 2019 14:48
@matianjun1
Copy link

matianjun1 commented May 29, 2020

@kamilogorek For v0.6.1 how about this feature?

@kamilogorek
Copy link
Contributor Author

I'm not sure what is the question here. We already shipped this change a long time ago.

@matianjun1
Copy link

I'm not sure what is the question here. We already shipped this change a long time ago.

@kamilogorek Sorry for my description. For the newest release. This feature has been remvoed. Both of the test code.

sentry-go/client_test.go

Lines 125 to 143 in af3076c

errorChainTests := []captureExceptionTest{
{
name: "MostRecentErrorHasStack",
err: pkgErrors.WithStack(&customErr{}),
want: []Exception{
{
Type: "*sentry.customErr",
Value: "wat",
// No Stacktrace, because we can't tell where the error came
// from and because we have a stack trace in the most recent
// error in the chain.
},
{
Type: "*errors.withStack",
Value: "wat",
Stacktrace: &Stacktrace{Frames: []Frame{}},
},
},
},

This should be *sentry.customErr not "*errors.withStack

@rhcarvalho
Copy link
Contributor

@matianjun1 in v0.6.0 we added full support for chained errors, see #185.

Now we report a complete chain of errors, as supported in other platforms and described here: https://develop.sentry.dev/sdk/event-payloads/exception/.

If you found a bug or have a feature request, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All errors show up as *errors.withStack
4 participants