Skip to content

Send extra information exposed by the Go runtime #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Send extra information exposed by the Go runtime #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions integrations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,11 @@ func (ei *environmentIntegration) processor(event *Event, hint *EventHint) *Even
}

event.Contexts["runtime"] = map[string]interface{}{
"name": "go",
"version": runtime.Version(),
"name": "go",
"version": runtime.Version(),
"go_numroutines": runtime.NumGoroutine(),
"go_maxprocs": runtime.GOMAXPROCS(0),
"go_numcgocalls": runtime.NumCgoCall(),
Comment on lines +201 to +203
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering whether the go prefix is okay with the tags, or should they be removed?

My gut instinct is to keep it, since its go specific information, not a generic maxprocs/routines info.
@kamilogorek Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are non-standard (in our UI) anyway and will be displayed as regular tags so this is totally fine. Thanks!

}

return event
Expand Down