-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): Add WithDescription SpanOption #751
feat(tracing): Add WithDescription SpanOption #751
Conversation
@natikgadzhi thanks for the PR! Just need to fix a linting issue and this should be good. :) |
@greywolve I do have to admit, not setting up a formatter in a Go project is kind of embarrasing. Fixed! |
Haha no problem, I forget this sometimes too :) |
Btw, perhaps worth setting up a .vscode/settings.json with custom formatter path to ensure gofmt -s by default?
|
Co-authored-by: Oliver Powell <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 80.77% 80.88% +0.11%
==========================================
Files 47 48 +1
Lines 4701 4714 +13
==========================================
+ Hits 3797 3813 +16
+ Misses 765 763 -2
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. |
Not sure everyone uses vscode, but that could be useful for sure. |
Summary
This pull request adds
WithDescription
span option! Closes #739, thank you to @moneymikeMD for the issue.Changes
WithDescription
SpanOption
that works similar to the existingWithTransactionName
and friends.TODO
tracing_test.go
. Wait a sec, will do in a couple hours./cc @greywolve