Allowing platform and SDK overrides #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of this can be achieved using |
|
This is not the same behavior. I shouldn't have to modify the event with a global handler. In this case I'd have to hold onto the attachments instead of just adding when constructing the event. |
|
The first part of the change, I, indeed, can achieve with BeforeSend. I will make that change to just be attachment modification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow overrides to the reported platform and SDK. This is useful if you're using the go library to convert and push other kinds of crashes (i.e. not go program crashes). Additionally, this allows you to add Event-specific attachments beyond the shared scope's.