-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support IgnoreTransactions client option #717
feat: support IgnoreTransactions client option #717
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍
Could you just add a bit of PR description and link to the issue it's fixing/implementing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to make sure this continues to work with the ignoreErrorsIntegration
that is currently controlled via the IgnoreErrors
option.
I suggest adding an ignoreTransactionsIntegration
, as we can't remove the ignoreErrorsIntegration
, which would cause issues for people using it today.
Hmm, my bad. I missed that |
@cleptric rework done. :) |
Adds support for ignoring transactions by using the
IgnoreTransactions
client option. This requires a slice of regex strings that are matched against a transaction's name. If there's a match the transaction is dropped.Fixes #628