Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module integration #65

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

faulkner
Copy link
Contributor

@faulkner faulkner commented Oct 5, 2019

NewEvent() doesn't return Modules as nil, which was preventing this integration from working.
The extra flag was added to prevent repeatedly trying to cache the modules if getModules() returned nil.

@faulkner
Copy link
Contributor Author

faulkner commented Oct 5, 2019

The failing test should be resolved by #66, but I can add it to this PR if that helps.

@faulkner faulkner force-pushed the fix-module-integration branch from 3eaad17 to 3d1490f Compare October 6, 2019 17:21
NewEvent() doesn't return Modules as nil, which was preventing this integration from working.
The extra flag was added to prevent repeatedly trying to cache the modules if getModules() returned nil.
@faulkner faulkner force-pushed the fix-module-integration branch from 3d1490f to 4284b62 Compare October 6, 2019 17:39
@kamilogorek kamilogorek merged commit 17042b2 into getsentry:master Oct 8, 2019
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants