-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump kataras/iris to 12.2.0-beta7 to resolve vulns #550
Conversation
Codecov ReportBase: 78.80% // Head: 76.55% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #550 +/- ##
==========================================
- Coverage 78.80% 76.55% -2.26%
==========================================
Files 38 30 -8
Lines 3860 3387 -473
==========================================
- Hits 3042 2593 -449
+ Misses 714 697 -17
+ Partials 104 97 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hey @mdtro , for additional context, could you link to the changelog, and/or vulnerability report please? |
Done! Apologies for not including it to begin with. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🏄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep in mind that we're forcing Sentry users to upgrade iris by merging this.
This is kinda against our philosophy, but we got a lot of complaints about the Go SDK triggering some false positives in weird security scanners.
@cleptric I understand the concern. We are only moving from beta5 to beta7, but that definitely moves a lot of the indirect dependencies forward quite a few versions. I second the SDKs generating false positives in the various security scanners. I used three different ones and ended up with three different answers. 🙃
|
This comment was marked as outdated.
This comment was marked as outdated.
Let's bite the bullet 😄 |
Ooph, the checks aren't happy. I'll add this to my list to dig in on early next week. |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Part of #595 |
Bumps
github.com/kataras/iris
fromv12.2.0-beta5
tov12.2.0-beta7
to resolve some transitive vulnerabilities.Resolves:
The CHANGELOG for v12.2.0-beta7 can be found here.