-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize stacktrace from 7.36kB to 2.30kB and speed too #467
Conversation
YaroslavPodorvanov
commented
Aug 20, 2022
•
edited
Loading
edited
frames = append([]Frame{ | ||
NewFrame(callerFrame), | ||
}, frames...) | ||
frames = append(frames, NewFrame(callerFrame)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is main optimization of NewStacktrace because append faster that prepend and use less memory
@kamilogorek can you review please? |
@bruno-garcia can you review code? |
@YaroslavPodorvanov I'll catch up on everything this week. We had company-wide hackweek, so everyone was slow to review external contributions :) |
Thanks 🙇 |