fix: check for dropped event #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gawen, good catch! ❤️ Would you like to add a test case? |
|
@rhcarvalho sure, although I don't see a relevant test case. |
|
The case is when an event processor in the scope drops an event. The default scope starts without any event processor, that's probably why the bug was hiding for a long time. |
scope.ApplyToEvent may return nil, but is not checked.
rhcarvalho
force-pushed
the
fix-check-nil-applytoevent
branch
from
4c1ea5d to
a568e41
Compare
|
I've rebased against current master and added a simple change to a test that minimally covers the change (the test breaks without the change from @gawen). |
rhcarvalho
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
@gawen thanks for your contribution! (not only with this one!!!)
|
@rhcarvalho thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope.ApplyToEventmay return nil, but is not checked inprepareEvent.