Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test against Go 1.14, drop 1.11 #170

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

rhcarvalho
Copy link
Contributor

Go 1.14 has been released, so update the versions we test against.

Testing of Module mode outside of GOPATH can use the latest stable
release, thus not requiring a config update with each release of Go 1.x.

Go 1.14 has been released, so update the versions we test against.

Testing of Module mode outside of GOPATH can use the latest stable
release, thus not requiring a config update with each release of Go 1.x.
@rhcarvalho
Copy link
Contributor Author

Note that we're not bumping the language version in go.mod. We may defer that until some later time.

With my current understanding, we should keep that to the lowest language version we support (i.e, if we change it we should bump from 1.11 to 1.12, not 1.14).

Since we don't require anything from 1.12+ right now, it seems okay to leave that alone for now.

@rhcarvalho rhcarvalho merged commit 4dddaaa into getsentry:master Feb 26, 2020
@rhcarvalho rhcarvalho deleted the go114 branch February 26, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant