Skip to content

fix(otel): Prefer http route over http target for span description #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giortzisg merged 5 commits into from
May 9, 2025
Merged

fix(otel): Prefer http route over http target for span description #1002

giortzisg merged 5 commits into from
May 9, 2025

Conversation

@OrkhanAlikhanov
Copy link
Contributor

@OrkhanAlikhanov OrkhanAlikhanov commented Apr 25, 2025

Fixes #999

@OrkhanAlikhanov OrkhanAlikhanov changed the title Enhancement/otel prefer http route fix(otel): Prefer http route over http target for span description Apr 25, 2025
@OrkhanAlikhanov OrkhanAlikhanov mentioned this pull request Apr 25, 2025
Closed
@giortzisg
Copy link
Contributor

giortzisg commented Apr 25, 2025 •
edited
Loading

Can we also add some more tests for checking the fallback options and that they correctly parse the urls? @OrkhanAlikhanov

@OrkhanAlikhanov
Copy link
Contributor Author

OrkhanAlikhanov commented Apr 28, 2025

Hello. Yes

@OrkhanAlikhanov
Copy link
Contributor Author

OrkhanAlikhanov commented Apr 29, 2025

@giortzisg I added more test cases

giortzisg
giortzisg reviewed Apr 30, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (6b014ea) to head (0575dad).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   84.00%   84.99%   +0.99%     
==========================================
  Files          50       50              
  Lines        5171     5173       +2     
==========================================
+ Hits         4344     4397      +53     
+ Misses        673      631      -42     
+ Partials      154      145       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

giortzisg
giortzisg approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@giortzisg giortzisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@OrkhanAlikhanov
Copy link
Contributor Author

OrkhanAlikhanov commented May 1, 2025

Thank you @giortzisg. Looking forward to seeing it released

@cleptric cleptric self-requested a review May 5, 2025 11:40
@cleptric cleptric added the Improvement Issue type label May 5, 2025
@giortzisg giortzisg merged commit bf20c9f into getsentry:master May 9, 2025
16 checks passed
@OrkhanAlikhanov OrkhanAlikhanov deleted the enhancement/otel-prefer-http-route branch May 9, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giortzisg giortzisg giortzisg approved these changes

@cleptric cleptric Awaiting requested review from cleptric

Assignees

@giortzisg giortzisg

Labels

Improvement Issue type

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Otel seems to prefer httpTarget over httpRoute

3 participants

@OrkhanAlikhanov @giortzisg @cleptric