-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel SDK casts all span data
values to string
#758
Comments
We are using https://pkg.go.dev/go.opentelemetry.io/[email protected]/attribute#Value.Emit - this forces everything to be strings sentry-go/otel/span_processor.go Line 129 in fff66d1
We should remove the casting. See https://opentelemetry.io/docs/concepts/signals/traces/#attributes
|
cc @cleptric |
) Apparently sometimes size fields like the request size can be strings like `"77"`. This PR makes sure they're parsed as such. See getsentry/sentry-go#758 - Add spec - Treat request size as a size field - Support string values for size fields Fixes JAVASCRIPT-2QGM
) Apparently sometimes size fields like the request size can be strings like `"77"`. This PR makes sure they're parsed as such. See getsentry/sentry-go#758 - Add spec - Treat request size as a size field - Support string values for size fields Fixes JAVASCRIPT-2QGM
Summary
Something in the interaction between Go and OTel is casting all span
data
values to strings, even well-known measurement fields likehttp.response_content_length
Steps To Reproduce
I found this data in the wild, so I don't have actual repro steps, sorry! I can provide more details if you contact me on Slack
Expected Behavior
data.http.response_content_length
is an integerScreenshots
Environment
SDK
sentry-go
version:0.25.0
opentelemetry
version:1.18.0
Sentry
The text was updated successfully, but these errors were encountered: