Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI from Travis to GitHub Actions #313

Closed
billyvg opened this issue Jan 5, 2021 · 12 comments · Fixed by #321
Closed

Migrate CI from Travis to GitHub Actions #313

billyvg opened this issue Jan 5, 2021 · 12 comments · Fixed by #321

Comments

@billyvg
Copy link
Member

billyvg commented Jan 5, 2021

Travis sprung some surprise billing changes on us awhile, so we are now prioritizing removing usage of TravisCI completely. This issue will be used by @getsentry/productivity to track overall progress across the organization, but please let us know here if there's anything we should be aware of.

@armenzg
Copy link
Member

armenzg commented Jan 5, 2021

@kamilogorek Is this referring to the main branch on https://github.com/golang/go ? I don't see an official support by the setup-go action so it might take some effort to obtain that functionality.

- master

@billyvg any suggestions on how to emulate Travis' webhook and notifications? (I see some unverified Webhook actions)

sentry-go/.travis.yml

Lines 51 to 59 in db5fae9

notifications:
webhooks:
urls:
- https://zeus.ci/hooks/befe9810-9285-11e9-b01a-0a580a281808/public/provider/travis/webhook
on_success: always
on_failure: always
on_start: always
on_cancel: always
on_error: always

@armenzg
Copy link
Member

armenzg commented Jan 5, 2021

@kamilogorek What's happening for this error?
https://github.com/armenzg/sentry-go/runs/1652741273?check_suite_focus=true

Run go build ./...
  go build ./...
  shell: /usr/bin/bash -e {0}
  env:
    GO111MODULE: off
    GOROOT: /opt/hostedtoolcache/go/1.14.13/x64
traces_sampler.go:6:2: cannot find package "github.com/getsentry/sentry-go/internal/crypto/randutil" in any of:
	/opt/hostedtoolcache/go/1.14.13/x64/src/github.com/getsentry/sentry-go/internal/crypto/randutil (from $GOROOT)
	/home/runner/go/src/github.com/getsentry/sentry-go/internal/crypto/randutil (from $GOPATH)
client.go:19:2: cannot find package "github.com/getsentry/sentry-go/internal/debug" in any of:
	/opt/hostedtoolcache/go/1.14.13/x64/src/github.com/getsentry/sentry-go/internal/debug (from $GOROOT)
	/home/runner/go/src/github.com/getsentry/sentry-go/internal/debug (from $GOPATH)

@billyvg
Copy link
Member Author

billyvg commented Jan 5, 2021

I would defer to Kamil re: how we want to handle zeus.

@armenzg
Copy link
Member

armenzg commented Jan 6, 2021

@kamilogorek Would I also be able to get write access? It will allow me to run the GH actions as part of the PR.

@rhcarvalho
Copy link
Contributor

What's happening for this error?

I think it's trying to build with GO111MODULE=off code checked-out outside of GOPATH, that won't work.
I need to see what's the best practice here, one solution is to set GOPATH explicitly to $GITHUB_WORKSPACE.

I would defer to Kamil re: how we want to handle zeus.

We don't need a replacement for Zeus, we already use GH to check build status in Craft (and note we don't need any artifact provider for Go), so we can remove the webhook without affecting the release process.

@rhcarvalho rhcarvalho linked a pull request Jan 11, 2021 that will close this issue
@armenzg
Copy link
Member

armenzg commented Jan 12, 2021

@billyvg @rhcarvalho would you mind reviewing this? #314

@armenzg
Copy link
Member

armenzg commented Jan 12, 2021

@rhcarvalho do you have some steps as to how to quickly get a go version from source checkout?

I'm looking at the Travis code and I can't figure out what steps are taken to get a development version installed.

@armenzg
Copy link
Member

armenzg commented Jan 14, 2021

Merged: #314
Next: #319

@rhcarvalho r? for #319

FYI You will need to change the "Required checks" at the repository level.

@armenzg
Copy link
Member

armenzg commented Jan 21, 2021

Hi @rhcarvalho how do you feel about dropping the Travis CI? No pressure. Just curious if there's anything left to validate.

@armenzg
Copy link
Member

armenzg commented Feb 17, 2021

@rhcarvalho Would it be possible to land this? In February, sentry-go used more than 50% of our Travis credits.

@armenzg
Copy link
Member

armenzg commented Feb 18, 2021

👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants