-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List of packages include "replace" package #184
Comments
I prototype it using
Result will be:
|
FTR for binaries built in Module Mode, there is https://golang.org/pkg/runtime/debug/#BuildInfo. |
@rhcarvalho Nice! it's works! |
wingyplus
pushed a commit
to wingyplus/sentry-go
that referenced
this issue
Apr 14, 2020
wingyplus
pushed a commit
to wingyplus/sentry-go
that referenced
this issue
Apr 14, 2020
wingyplus
pushed a commit
to wingyplus/sentry-go
that referenced
this issue
Apr 14, 2020
wingyplus
added a commit
to wingyplus/sentry-go
that referenced
this issue
Apr 14, 2020
@rhcarvalho I opened PR to fix this problem. It's good to see your feedback. :) |
rhcarvalho
pushed a commit
to wingyplus/sentry-go
that referenced
this issue
Apr 17, 2020
rhcarvalho
added a commit
that referenced
this issue
Apr 17, 2020
runtime/debug.ReadBuildInfo is more reliable than manually parsing a `go.mod` file, specially without assistance from golang.org/x/mod/modfile. Another advantage is that it doesn't require `go.mod` and source code to be available. We also now include the current module (the module with package main) in the list of modules. runtime/debug.ReadBuildInfo requires go 1.12, which is already the minimum supported Go version. Thus bump the language version in go.mod. Drop support for reading dependencies from govendor's `vendor/vendor.json`. Fixes #184. Fixes #197. Co-authored-by: Rodolfo Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Among packages from
go.mod
, package list is also showing areplace
entry, looks wrong:Here's the code that needs improvement:
sentry-go/integrations.go
Lines 70 to 104 in a0f55ee
The text was updated successfully, but these errors were encountered: