feat(starfish): add http.request.method attribute to span data (#786)

* feat(starfish): add attribute to span data * test: add Extra field on gin tests * chore: add changelog --------- Co-authored-by: Emir Ribić <[email protected]> Co-authored-by: Ivan Dlugos <[email protected]>
getsentry · Mar 26, 2024 · 08cdc59 · 08cdc59
1 parent a084ac9
commit 08cdc59
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 - Accept `interface{}` for span data values ([#784](https://github.com/getsentry/sentry-go/pull/784))
 - Automatic transactions for Echo integration ([#722](https://github.com/getsentry/sentry-go/pull/722))
+- Add `http.request.method` attribute for performance span data ([#786](https://github.com/getsentry/sentry-go/pull/786))
 - Automatic transactions for Fasthttp integration ([#732](https://github.com/getsentry/sentry-go/pull/723))
 - Add `Fiber` integration ([#795](https://github.com/getsentry/sentry-go/pull/795))
 

diff --git a/gin/sentrygin.go b/gin/sentrygin.go
@@ -83,6 +83,7 @@ func (h *handler) handle(c *gin.Context) {
 		fmt.Sprintf("%s %s", c.Request.Method, transactionName),
 		options...,
 	)
+	transaction.SetData("http.request.method", c.Request.Method)
 	defer func() {
 		transaction.Status = sentry.HTTPtoSpanStatus(c.Writer.Status())
 		transaction.Finish()

diff --git a/gin/sentrygin_test.go b/gin/sentrygin_test.go
@@ -53,6 +53,7 @@ func TestIntegration(t *testing.T) {
 					},
 				},
 				TransactionInfo: &sentry.TransactionInfo{Source: "route"},
+				Extra:           map[string]interface{}{"http.request.method": string("GET")},
 			},
 			WantEvent: &sentry.Event{
 				Level:   sentry.LevelFatal,
@@ -86,6 +87,7 @@ func TestIntegration(t *testing.T) {
 					},
 				},
 				TransactionInfo: &sentry.TransactionInfo{Source: "url"},
+				Extra:           map[string]interface{}{"http.request.method": string("GET")},
 			},
 			WantEvent: nil,
 		},
@@ -119,6 +121,7 @@ func TestIntegration(t *testing.T) {
 					},
 				},
 				TransactionInfo: &sentry.TransactionInfo{Source: "route"},
+				Extra:           map[string]interface{}{"http.request.method": string("POST")},
 			},
 			WantEvent: &sentry.Event{
 				Level:   sentry.LevelInfo,
@@ -158,6 +161,7 @@ func TestIntegration(t *testing.T) {
 					},
 				},
 				TransactionInfo: &sentry.TransactionInfo{Source: "route"},
+				Extra:           map[string]interface{}{"http.request.method": string("GET")},
 			},
 			WantEvent: &sentry.Event{
 				Level:   sentry.LevelInfo,
@@ -200,6 +204,7 @@ func TestIntegration(t *testing.T) {
 					},
 				},
 				TransactionInfo: &sentry.TransactionInfo{Source: "route"},
+				Extra:           map[string]interface{}{"http.request.method": string("POST")},
 			},
 			WantEvent: &sentry.Event{
 				Level:   sentry.LevelInfo,
@@ -243,6 +248,7 @@ func TestIntegration(t *testing.T) {
 					},
 				},
 				TransactionInfo: &sentry.TransactionInfo{Source: "route"},
+				Extra:           map[string]interface{}{"http.request.method": string("POST")},
 			},
 			WantEvent: &sentry.Event{
 				Level:   sentry.LevelInfo,
@@ -281,6 +287,7 @@ func TestIntegration(t *testing.T) {
 					},
 				},
 				TransactionInfo: &sentry.TransactionInfo{Source: "route"},
+				Extra:           map[string]interface{}{"http.request.method": string("GET")},
 			},
 			WantEvent: nil,
 		},

diff --git a/http/sentryhttp.go b/http/sentryhttp.go
@@ -105,6 +105,7 @@ func (h *Handler) handle(handler http.Handler) http.HandlerFunc {
 			fmt.Sprintf("%s %s", r.Method, r.URL.Path),
 			options...,
 		)
+		transaction.SetData("http.request.method", r.Method)
 		defer transaction.Finish()
 		// TODO(tracing): if the next handler.ServeHTTP panics, store
 		// information on the transaction accordingly (status, tag,