Repository navigation
fix: builds no longer fail when symbol upload or release creation is enabled but no Sentry auth token is available - #5705
Merged
Conversation
PrepareSentryCLI probes with `sentry-cli info` and skips uploads and release creation when it fails. Since sentry-cli 2.30.0 that command prints `error: ...` when it has no token (or the API request fails), and MSBuild parsed that line as a build error despite IgnoreExitCode, so the build failed before the skip could take effect. Fixes #5704 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5705 +/- ##
=======================================
Coverage 75.22% 75.22%
=======================================
Files 516 516
Lines 19022 19022
Branches 3698 3698
=======================================
+ Hits 14309 14310 +1
+ Misses 3858 3857 -1
Partials 855 855 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ric-oliv
approved these changes
Oct 12, 2026
3 tasks done
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrepareSentryCLIrunssentry-cli infoto decide whether the CLI is configured, and skips uploads and release creation if it isn't. Since sentry-cli 2.30.0 (#3203),infoprintserror: Auth token is required…when there's no token, orerror: API request failedwhen the token is bad or the server can't be reached. The probe'sExecignored the exit code but still parsed that line as an MSBuild error, so the build failed before the skip could happen. That broke every build withSentryUploadSymbols,SentryUploadSourcesorSentryCreateReleaseenabled and no token: fork PRs, local Release builds, anddocker buildwithout the secret.IgnoreStandardErrorWarningFormat="true", so a failinginfofalls through to the existing skip logic.error: …and "Please attach the full debug log" lines at the default verbosity.Closes #5704
Notes for review
-warnaserrorstill fails the build./p:SentryCLI. The targets can't clear a global property, so the skip path couldn't be tested the old way. The new cases fail without the fix.🤖 Generated with Claude Code