Skip to content

fix: bound profiler memory growth by trimming interned call stacks - #5503

Merged
jamescrosswell merged 20 commits into
mainfrom
fix/5469-trim-live-session-state
Aug 31, 2026
Merged

jamescrosswell merged 20 commits into
mainfrom
fix/5469-trim-live-session-state

Make the call stack budget per-factory rather than a static

908f26f
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Aug 31, 2026 in 0s

1 issue

High

AddSample keeps processing after trim instead of skipping the invalidated sample - `src/Sentry.Profiling/SampleProfileBuilder.cs:57-61`

When trim generation changes, clear _stackIndexes and return immediately; the current event's CallStackIndex was invalidated by TrimLiveSessionState, and continuing can cache a bad stack under a recycled index.

4 skills analyzed
Skill Findings Duration Cost
security-review 0 14.2s $0.11
code-review 0 12m 17s $1.71
find-bugs 1 31m 33s $3.83
gha-security-review 0 17m 48s $0.06

⏱ 61m 52s · 4.2M in / 373.9k out · $5.71