Skip to content

fix: return early from AddSentryOtlpExporter when DSN is the disable-SDK sentinel #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 1 commit into from
May 21, 2026
Merged

fix: return early from AddSentryOtlpExporter when DSN is the disable-SDK sentinel #5247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Sentry.OpenTelemetry.Exporter/SentryTracerProviderBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ public static class SentryTracerProviderBuilderExtensions
public static TracerProviderBuilder AddSentryOtlpExporter(this TracerProviderBuilder tracerProviderBuilder,
string dsnString, Uri? collectorUrl = null, TextMapPropagator? defaultTextMapPropagator = null)
{
if (Dsn.IsDisabled(dsnString))
{
return tracerProviderBuilder;
}

if (Dsn.TryParse(dsnString) is not { } dsn)
{
throw new ArgumentException(MissingDsnWarning, nameof(dsnString));
Expand Down
15 changes: 14 additions & 1 deletion test/Sentry.OpenTelemetry.Exporter.Tests/SentryTracerProviderBuilderExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ public class SentryTracerProviderBuilderExtensionsTests
{
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData("foo")]
public void AddSentryOtlpExporter_InvalidDsn_ThrowsArgumentException(string dsn)
{
Expand All @@ -22,6 +21,20 @@ public void AddSentryOtlpExporter_InvalidDsn_ThrowsArgumentException(string dsn)
.WithMessage($"{SentryTracerProviderBuilderExtensions.MissingDsnWarning}*");
}

[Fact]
public void AddSentryOtlpExporter_DisabledSdkDsn_ReturnsWithoutConfiguringExporter()
{
// Arrange
var tracerProviderBuilder = Substitute.For<TracerProviderBuilder>();

// Act
var result = tracerProviderBuilder.AddSentryOtlpExporter(SentryConstants.DisableSdkDsnValue);

// Assert
result.Should().BeSameAs(tracerProviderBuilder);
tracerProviderBuilder.DidNotReceive().AddInstrumentation(Arg.Any<Func<object>>());
}

[Fact]
public void OtlpConfigurationCallback_WithCustomCollectorUrl_SetsEndpointToCustomUrl()
{
Expand Down
Loading