Skip to content

feat: propagate trace to sentry-android and sentry-cocoa #5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 1 commit into from
May 19, 2026
Merged

feat: propagate trace to sentry-android and sentry-cocoa #5244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Sentry/Platforms/Android/AndroidScopeObserver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ public void SetUser(SentryUser? user)

public void SetTrace(SentryId traceId, SpanId parentSpanId)
{
// TODO: This requires sentry-java 8.4.0
try
{
JavaSdk.Android.Core.InternalSentrySdk.SetTrace(traceId.ToString(), parentSpanId.ToString(), null, null);
}
finally
{
_innerObserver?.SetTrace(traceId, parentSpanId);
}
}

public void AddAttachment(SentryAttachment attachment)
Expand Down
9 changes: 8 additions & 1 deletion src/Sentry/Platforms/Cocoa/CocoaScopeObserver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,14 @@ public void SetUser(SentryUser? user)

public void SetTrace(SentryId traceId, SpanId parentSpanId)
{
// TODO: Missing corresponding functionality on the Cocoa SDK
try
{
SentryCocoaHybridSdk.SetTrace(traceId.ToCocoaSentryId(), parentSpanId.ToCocoaSpanId());
}
finally
{
_innerObserver?.SetTrace(traceId, parentSpanId);
}
}

public void AddAttachment(SentryAttachment attachment)
Expand Down
Loading