-
-
Notifications
You must be signed in to change notification settings - Fork 229
fix: Apply Enricher to User Feedback
#4883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -108,6 +108,7 @@ public SentryId CaptureFeedback(SentryFeedback feedback, out CaptureFeedbackResu | |||||||||
| // Evaluate and copy before invoking the callback | ||||||||||
| scope.Evaluate(); | ||||||||||
| scope.Apply(evt); | ||||||||||
| _enricher.Apply(evt); | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: more than More than
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like we already do this here as well... sentry-dotnet/src/Sentry/SentryClient.cs Lines 177 to 180 in fed5244
Maybe we refactor it into a tiny little method (which could conceivably be reused in CaptureCheckIn, CaptureSession or some other future CaptureFoo method)? That way we'd ensure consistency across envelope items.
Flash0ver marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
|
|
||||||||||
| if (scope.Level != null && scope.Level != SentryLevel.Info) | ||||||||||
| { | ||||||||||
|
|
||||||||||
Uh oh!
There was an error while loading. Please reload this page.