-
-
Notifications
You must be signed in to change notification settings - Fork 226
feat(logs)!: change from ParentSpanId attribute to SpanId protocol #4778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4778 +/- ##
==========================================
- Coverage 73.90% 73.89% -0.02%
==========================================
Files 485 485
Lines 17686 17682 -4
Branches 3494 3494
==========================================
- Hits 13071 13066 -5
Misses 3758 3758
- Partials 857 858 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sentry review |
| /// The span id of the span that was active when the log was collected. | ||
| /// </summary> | ||
| public SpanId? ParentSpanId { get; init; } | ||
| public SpanId? SpanId { get; init; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitsandfoxes this change should not break sentry-unity.
However, it may break user code calling:
SentryOptions.SetBeforeSendLog(Func<SentryLog, SentryLog?>)
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's less confusing to be honest - thanks @Flash0ver !
Change Structured Logs in order to reflect: getsentry/sentry-docs#15355
SentryLog.ParentSpanIdtoSentryLog.SpanIdsentry.trace.parent_span_idattribute tospan_idprotocol propertyBefore

After
