Skip to content

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Dec 1, 2025

Change Structured Logs in order to reflect: getsentry/sentry-docs#15355

  • Rename SentryLog.ParentSpanId to SentryLog.SpanId
  • Change sentry.trace.parent_span_id attribute to span_id protocol property

Before
image

After
image

@Flash0ver Flash0ver self-assigned this Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b28a42c

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.89%. Comparing base (613a18d) to head (b28a42c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4778      +/-   ##
==========================================
- Coverage   73.90%   73.89%   -0.02%     
==========================================
  Files         485      485              
  Lines       17686    17682       -4     
  Branches     3494     3494              
==========================================
- Hits        13071    13066       -5     
  Misses       3758     3758              
- Partials      857      858       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flash0ver
Copy link
Member Author

@sentry review

@Flash0ver Flash0ver marked this pull request as ready for review December 1, 2025 16:35
/// The span id of the span that was active when the log was collected.
/// </summary>
public SpanId? ParentSpanId { get; init; }
public SpanId? SpanId { get; init; }
Copy link
Member Author

@Flash0ver Flash0ver Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitsandfoxes this change should not break sentry-unity.

However, it may break user code calling:

  • SentryOptions.SetBeforeSendLog(Func<SentryLog, SentryLog?>)

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's less confusing to be honest - thanks @Flash0ver !

@Flash0ver Flash0ver merged commit 8df9302 into main Dec 3, 2025
38 checks passed
@Flash0ver Flash0ver deleted the logs/new-span_id-protocol branch December 3, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants