Skip to content

Temporary workaround for GetRuntime_AllProperties failing on WinArm64 #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 11, 2025
Merged

Temporary workaround for GetRuntime_AllProperties failing on WinArm64 #4713

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef0993a
Added logging info
jamescrosswell Nov 10, 2025
c87dce7
Use ITestOutputHelper
jamescrosswell Nov 10, 2025
37dd2a0
More explicit failure reasons
jamescrosswell Nov 10, 2025
dd5c969
.
jamescrosswell Nov 10, 2025
f3f8c3d
skip check on WinArm64 for now
jamescrosswell Nov 10, 2025
43822ed
.
jamescrosswell Nov 11, 2025
7a4bbdb
.
jamescrosswell Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions test/Sentry.Tests/PlatformAbstractions/RuntimeInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,19 @@

namespace Sentry.Tests.PlatformAbstractions;

public class RuntimeInfoTests
public class RuntimeInfoTests(ITestOutputHelper output)
{
[Fact]
public void GetRuntime_AllProperties()
{
var frameworkDescription = RuntimeInformation.FrameworkDescription;
output.WriteLine($"RuntimeInformation.FrameworkDescription: {frameworkDescription}");

var actual = RuntimeInfo.GetRuntime();
Assert.NotNull(actual);
Assert.NotNull(actual.Name);
Assert.NotNull(actual.Version);
Assert.NotNull(actual.Raw);
actual.Should().NotBeNull("GetRuntime returned null");
actual.Name.Should().NotBeNull("Runtime Name is null");
actual.Version.Should().NotBeNull("Runtime Version is null");
actual.Raw.Should().NotBeNull("Runtime Raw is null");

#if NET5_0_OR_GREATER
Assert.Equal(".NET", actual.Name);
Expand All @@ -20,13 +23,18 @@ public void GetRuntime_AllProperties()
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
Assert.Equal(".NET Framework", actual.Name);
Assert.NotNull(actual.FrameworkInstallation);
Assert.NotNull(actual.FrameworkInstallation.Version);
actual.FrameworkInstallation.Should().NotBeNull("FrameworkInstallation is null");
// TODO: Windows ARM64 broke in CI... the timing wasn't very good (same day .NET 10 was announced) and I
// don't have a Windows ARM64 device to test on. Will need to debug in CI when we've released V6.
if (RuntimeInformation.ProcessArchitecture != Architecture.Arm64)
{
actual.FrameworkInstallation.Version.Should().NotBeNull("FrameworkInstallation.Version is null");
}
}
else
{
Assert.Equal("Mono", actual.Name);
Assert.Null(actual.FrameworkInstallation);
actual.FrameworkInstallation.Should().BeNull("FrameworkInstallation is not null");
}
#endif
}
Expand Down
Loading