-
-
Notifications
You must be signed in to change notification settings - Fork 226
feat: Cache Unhandled session instead of sending it immediately
#4653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entry/sentry-dotnet into feat/session-type-unhandled
Contributor
|
This was referenced Dec 7, 2025
This was referenced Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4632
Followup on #4633
Problem
Sessions that end in
Unhandledcan later on still crash. Updating a session with an end status is a terminal operation, see getsentry/sentry-docs#15086 and once updated, sessions must not receive further updates. We need to make sure the SDK finishes a session only when it is confident, that a session is actually finished.Proposal
Instead of updating (and ending) a session with
SessionEndStatus.Unhandledright away we persist the state to disk. We can make use of the fact that there is a separation betweenPersistedSessionUpdateandSessionUpdate.PersistedSessionUpdateis used locally only, the SDK does not send this to Sentry and we can add a flagPendingUnhandledto itSessionUpdateis the actual update the SDK sends to SentryThe flow is as follows:
Unhandledand the update is persisted to diskCrashed, overwriting the pending unhandled stateExitedwithUnhandled.TODO
Currently, the SDK relies on restarts of the application to send the
SessionEndStatus. Ideally, we would also hook into some shutdown mechanism, or at the very least, closing the SDK should also end any active sessions.