Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Oct 15, 2025

SelfContained=true helps for:

error NETSDK1112: The runtime pack for Microsoft.Android.Runtime.35.android-x64 was not downloaded. Try running a NuGet restore.

https://github.com/getsentry/sentry-dotnet/actions/runs/18515891743/job/52775923191?pr=4634

#skip-changelog

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.53%. Comparing base (f27f822) to head (32959f3).
⚠️ Report is 2 commits behind head on merge-main-5-16-1.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           merge-main-5-16-1    #4638      +/-   ##
=====================================================
- Coverage              73.13%   72.53%   -0.60%     
=====================================================
  Files                    480      465      -15     
  Lines                  17396    16998     -398     
  Branches                3429     3341      -88     
=====================================================
- Hits                   12722    12330     -392     
- Misses                  3816     3817       +1     
+ Partials                 858      851       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

<SingleProject>true</SingleProject>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<SelfContained>true</SelfContained>
Copy link
Member

@Flash0ver Flash0ver Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soft-✅ from me

TODO: merge this to main and update merge-main-5-16-1

Copy link
Collaborator

@jamescrosswell jamescrosswell Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd avoid updating merge-main-5-16-1 from main again... it will mess with the changelog now that we have Unreleased changes in there.

I might cherry pick that Kestrel security fix instead of merging from main again...

@jpnurmi jpnurmi changed the base branch from merge-main-5-16-1 to main October 15, 2025 16:24
@jpnurmi jpnurmi force-pushed the jpnurmi/android-device-tests branch from cd67dfb to 011230a Compare October 15, 2025 16:25
@jpnurmi jpnurmi changed the base branch from main to merge-main-5-16-1 October 15, 2025 16:55
@jpnurmi jpnurmi force-pushed the jpnurmi/android-device-tests branch from 011230a to 32959f3 Compare October 15, 2025 16:56
@jamescrosswell jamescrosswell merged commit 196647a into merge-main-5-16-1 Oct 16, 2025
25 of 28 checks passed
@jamescrosswell jamescrosswell deleted the jpnurmi/android-device-tests branch October 16, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants