Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jul 16, 2025

Example run: https://github.com/getsentry/sentry-dotnet/actions/runs/16322534643/job/46104110633 (I had this commit cherry-picked into #4347)

Resolves: #4355

#skip-changelog

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @jpnurmi

I left a comment on the issue... So basically I'm wondering what happens if the logs don't exist because the run fails before getting to the build step. Is that a problem or will it handle that gracefully?

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Jul 17, 2025

This is how it behaves with the different if-no-files-found values:

  • if-no-files-found: ignore

    image
  • if-no-files-found: warn (default)

    image
  • if-no-files-found: error

    image

Either ignore or warn works for this use case. I think it's a matter of taste. ignore outputs a quiet message in the step, while warn produces an annotation in the job summary. Which do you like more? :)

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jpnurmi jpnurmi merged commit 75452be into main Jul 17, 2025
26 checks passed
@jpnurmi jpnurmi deleted the ci/always-upload-msbuild-logs branch July 17, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): MSBuild binlogs are not uploaded as artifact when build fails

3 participants