Rename MemoryInfo.AllocatedBytes to MemoryInfo.TotalAllocatedBytes #4243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnapSac
requested review from
Flash0ver,
aritchie and
jamescrosswell
as code owners
KnapSac
commented
Jun 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4243 +/- ##
==========================================
- Coverage 75.73% 73.05% -2.68%
==========================================
Files 357 456 +99
Lines 13466 16559 +3093
Branches 2671 3302 +631
==========================================
+ Hits 10198 12097 +1899
- Misses 2593 3612 +1019
- Partials 675 850 +175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jamescrosswell
approved these changes
Jun 2, 2025
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
Thanks heaps for raising and addressing this @KnapSac !
leeandher
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jun 23, 2025
<!-- Describe your PR here. --> Adds the `total_allocated_bytes` property added in getsentry/sentry-dotnet#4243 to the static types. cc @jamescrosswell <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4242.