Skip to content

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented May 5, 2025

from #4158 (comment)

for PR #4158

Polyfill v1.32.0 includes System.Diagnostics.CodeAnalysis.ExperimentalAttribute.

Alternatively, we could update to a later version of Polyfill as well, or the current latest version.
Where e.g. v1.34.0 includes the System.Runtime.CompilerServices.DefaultInterpolatedStringHandler which the compiler then chooses for interpolated strings. This should have a positive effect on performance when using interpolated strings in our codebase targeting TFMs less than net6.0.

Updating Polyfill in a this PR separately in order to run tests in an isolated fashion because the compiler may pick up new types that now become (internally) accessible.

@jamescrosswell jamescrosswell merged commit 2ef75ce into main May 5, 2025
29 checks passed
@jamescrosswell jamescrosswell deleted the build/deps/bump-Polyfill-v1.23.0 branch May 5, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants