fix: Redact Authorization header before sending events to Sentry #4164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
commented
May 4, 2025
jamescrosswell
changed the title
jamescrosswell
commented
May 7, 2025
|
|
||
| internal class RedactedHeaders : IDictionary<string, string> | ||
| { | ||
| private static readonly string[] SensitiveKeys = ["Authorization", "Proxy-Authorization"]; |
Collaborator
Author
There was a problem hiding this comment.
We could be a bit more aggressive there. The Python SDK redacts a bunch of headers.
See Potential suspects.
aritchie
approved these changes
May 7, 2025
bruno-garcia
reviewed
May 7, 2025
src/Sentry/Protocol/Response.cs
Outdated
| Cookies = cookies, | ||
| Data = data, | ||
| InternalHeaders = headers?.WhereNotNullValue().ToDict(), | ||
| InternalHeaders = headers.Redact(), |
Member
There was a problem hiding this comment.
With the implicit operator, do we need to call the method here?
Collaborator
Author
There was a problem hiding this comment.
We do unfortunately. InternalHeaders is nullable and that can't be done with an implicit operator.
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4163: