Prevent leaking event hooks in our MauiEventHandler #4159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w cell reuse/etc don't cause us to hook event multiple times
bruno-garcia
approved these changes
May 2, 2025
bruno-garcia
added a commit
that referenced
this pull request
Jun 12, 2025
This reverts commit f92814d.
Closed
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection views, Carousel Views, or any control that has reusable cells - has events that have us calling for hooks on controls where we may already have them (ie. Button with a CV cell). Due to events being multicast, we end adding a hook and never removing the previous one. To make this issue worse, because our SentryMauiEventBinder is singleton - it means controls and therefore their entire page - unable to cleanup.
This PR shouldn't require additional tests since logic hasn't changed.