Skip to content

Conversation

@aritchie
Copy link
Contributor

@aritchie aritchie commented Mar 3, 2025

Resolve #4018

Was unable to reproduce the issue, but the issue reported was clear to show where the problem existed. One user had reported coming from v4 to v5. I wonder if there was some old reports that weren't versioned properly?

  • Safety all of the native serialization to & from dotnet
  • Ensure ToDictionary call in serialization mechanism checks if the value can be pulled as a raw string from json
  • End-to-end tests for (de)serializing native android SentryEvents
  • Only enable the Android callback if SuppressSegfault is true OR native EnableBeforeSend is true OR BeforeSend options callback is NOT null

@aritchie aritchie marked this pull request as ready for review March 3, 2025 22:23
@aritchie aritchie requested a review from jamescrosswell as a code owner March 3, 2025 22:23
@jamescrosswell jamescrosswell self-requested a review March 4, 2025 21:12
@jamescrosswell jamescrosswell merged commit 1f56e7e into main Mar 4, 2025
22 checks passed
@jamescrosswell jamescrosswell deleted the 4018-jsonelementhaswrongtype_android_breadcrumb branch March 4, 2025 21:12
@albyrock87
Copy link
Contributor

albyrock87 commented Mar 7, 2025

We're planning on releasing a new version on Monday, are you going to release a 5.2.1 today or on Monday with this fix?
I'm basically asking for ETA to better plan our next release.
Thanks! :)

@aritchie
Copy link
Contributor Author

aritchie commented Mar 7, 2025

@albyrock87 5.3.0 is releasing today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonElementHasWrongType, String, Number

5 participants