-
-
Notifications
You must be signed in to change notification settings - Fork 226
Support sending User Feedback without errors/exceptions #3981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ry-dotnet into feedback
| <Label Text="Name" Margin="0,20,0,0" /> | ||
| <Entry x:Name="NameEntry" Placeholder="Enter your name" /> | ||
|
|
||
| <Button Text="Attach Screenshot" Clicked="OnAttachScreenshotClicked" Margin="0,20,0,0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we can use this to create a built-in Widget like @armcknight built for iOS
Or use bindings to use the native one. But with a MAUI implementation means we have it also on Windows and macOS
| _options.LogInfo("Capturing event."); | ||
|
|
||
| var evt = new SentryEvent { Level = SentryLevel.Info }; | ||
| evt.Contexts.Feedback = feedback; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this odd. Are we trying to find a way to attach the feedback to the event somehow?
Could the feedback inherit from SentryEvent instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not without changing all the other SDKs. This is just how the spec says we should be doing it.
|
Can there be an
|
That particular example shows the It's really just a convenience. As a workaround, in the meantime, the same can be achieved by: using (var scopeTracker = SentrySdk.PushScope())
{
SentrySdk.ConfigureScope(s =>
{
s.SetTag("my-tag", "my value");
s.User = new SentryUser
{
Id = "42",
Email = "[email protected]"
};
});
var feedback = new SentryFeedback(message, contactEmail, name);
SentrySdk.CaptureFeedback(feedback, hint: hint);
}Note that the temporary local scope gets popped when |
Resolves #3605:
Related
Example