Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Java SDK to v7.12.1 #3503

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bumps scripts/update-java.ps1 from 7.11.0 to 7.12.1.

Auto-generated by a dependency updater.

Changelog

7.12.1

Fixes

  • Check app start spans time and ignore background app starts (#3550)
    • This should eliminate long-lasting App Start transactions

7.12.0

Features

  • Session Replay Public Beta (#3339)

    To enable Replay use the sessionReplay.sessionSampleRate or sessionReplay.errorSampleRate experimental options.

    import io.sentry.SentryReplayOptions
    import io.sentry.android.core.SentryAndroid
    
    SentryAndroid.init(context) { options ->
     
      // Currently under experimental options:
      options.experimental.sessionReplay.sessionSampleRate = 1.0
      options.experimental.sessionReplay.errorSampleRate = 1.0
    
      // To change default redaction behavior (defaults to true)
      options.experimental.sessionReplay.redactAllImages = true
      options.experimental.sessionReplay.redactAllText = true
    
      // To change quality of the recording (defaults to MEDIUM)
      options.experimental.sessionReplay.quality = SentryReplayOptions.SentryReplayQuality.MEDIUM // (LOW|MEDIUM|HIGH)
    }

    To learn more visit Sentry's Mobile Session Replay documentation page.

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Jul 26, 2024
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-java.ps1/7.12.1 branch from fabf852 to 34af2df Compare July 26, 2024 03:00
@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Jul 31, 2024

Getting an unusual error here:

Argument 1: cannot convert from 'Sentry.JavaSdk.JsonObjectReader' to 'Sentry.JavaSdk.IObjectReader'

Note: We didn't have this issue before as SentryEvent.Deserialize accepted a parameter of the class type rather than the interface type before this change.

It's possible to get around this by defining a partial class that indicates JsonObjectReader implements IObjectReader:

namespace Sentry.JavaSdk;

internal sealed partial class JsonObjectReader : IObjectReader
{

}

But we don't want to do that... I think we should correct the source code generation instead. Currently the c# code it generates for JsonObjectReader does not implement that interface (even though the api.xml file definitely indicates that it does/should in Java):

    <interface abstract="true" deprecated="not deprecated" final="false" name="ObjectReader" static="false" visibility="public" jni-signature="Lio/sentry/ObjectReader;">
       <!--   Rest of interface removed for brevity   -->
    </interface>

    <class abstract="false" deprecated="not deprecated" extends="java.lang.Object" extends-generic-aware="java.lang.Object" jni-extends="Ljava/lang/Object;" final="true" name="JsonObjectReader" static="false" visibility="public" jni-signature="Lio/sentry/JsonObjectReader;">
      <implements name="io.sentry.ObjectReader" name-generic-aware="io.sentry.ObjectReader" jni-type="Lio/sentry/ObjectReader;" />
       <!--   Rest of class removed for brevity   -->
    </class>

@jamescrosswell
Copy link
Collaborator

It looks very similar to this issue, but adding something similar to our proguard config doesn't appear to resolve the issue in our case.

@bitsandfoxes bitsandfoxes merged commit a029918 into main Aug 1, 2024
22 checks passed
@bitsandfoxes bitsandfoxes deleted the deps/scripts/update-java.ps1/7.12.1 branch August 1, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants