-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Java SDK to v7.12.1 #3503
Conversation
fabf852
to
34af2df
Compare
Getting an unusual error here:
Note: We didn't have this issue before as SentryEvent.Deserialize accepted a parameter of the class type rather than the interface type before this change. It's possible to get around this by defining a partial class that indicates namespace Sentry.JavaSdk;
internal sealed partial class JsonObjectReader : IObjectReader
{
} But we don't want to do that... I think we should correct the source code generation instead. Currently the c# code it generates for JsonObjectReader does not implement that interface (even though the <interface abstract="true" deprecated="not deprecated" final="false" name="ObjectReader" static="false" visibility="public" jni-signature="Lio/sentry/ObjectReader;">
<!-- Rest of interface removed for brevity -->
</interface>
<class abstract="false" deprecated="not deprecated" extends="java.lang.Object" extends-generic-aware="java.lang.Object" jni-extends="Ljava/lang/Object;" final="true" name="JsonObjectReader" static="false" visibility="public" jni-signature="Lio/sentry/JsonObjectReader;">
<implements name="io.sentry.ObjectReader" name-generic-aware="io.sentry.ObjectReader" jni-type="Lio/sentry/ObjectReader;" />
<!-- Rest of class removed for brevity -->
</class> |
It looks very similar to this issue, but adding something similar to our proguard config doesn't appear to resolve the issue in our case. |
Bumps scripts/update-java.ps1 from 7.11.0 to 7.12.1.
Auto-generated by a dependency updater.
Changelog
7.12.1
Fixes
7.12.0
Features
Session Replay Public Beta (#3339)
To enable Replay use the
sessionReplay.sessionSampleRate
orsessionReplay.errorSampleRate
experimental options.To learn more visit Sentry's Mobile Session Replay documentation page.