Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added .NET8 as TFM for Blazor.WebAssembly package #3501

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

bitsandfoxes
Copy link
Contributor

Addresses #2021 (comment)

Since the package has a dependency on Microsoft.AspNetCore.Components.WebAssembly adding .NET 8 as TFM allows users to resolve the actual .NET 8 dependency chain.

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ef63c49

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamescrosswell jamescrosswell merged commit d126142 into main Jul 26, 2024
23 checks passed
@jamescrosswell jamescrosswell deleted the feat/blzr-net8 branch July 26, 2024 12:48
@klemmchr
Copy link

Should this be done for other libraries like Sentry.AspNetCore.Grpc as well?

@bitsandfoxes
Copy link
Contributor Author

Should this be done for other libraries like Sentry.AspNetCore.Grpc as well?

As far as I can tell, either none of those have TFM version specific dependendencies or they are (like Sentry.AspNetCore) already targeting .NET8.

@klemmchr
Copy link

klemmchr commented Aug 19, 2024

At least the mentioned package Sentry.AspNetCore.Grpc has a dependency on Sentry.AspNetCore which has TFM version specific dependencies. Same applies to Sentry.Google.Cloud.Functions. I didn't check all packages though.

@bitsandfoxes
Copy link
Contributor Author

And we're building versions for those

<TargetFrameworks>net8.0;net6.0</TargetFrameworks>

@klemmchr
Copy link

klemmchr commented Aug 20, 2024

Sorry, I was unclear about what I mean. Since Sentry.AspNetCore has TFM version specific dependencies, dependant packages (like Sentry.AspNetCore.Grpc and Sentry.Google.Cloud.Functions) should build net8.0 as well but they don't at the moment. Unless I misunderstand the argument made for Blazor.WebAssembly.

@bitsandfoxes
Copy link
Contributor Author

It's about the package's dependencies: Sentry.AspNetCore and Sentry.AspNetCore.Blazor.WebAssembly have TFM-dependent dependencies. I.e. Microsoft.AspNetCore.Components.WebAssembly v6 and v8. Same for Microsoft.Extensions.Configuration.Binder.

Looking through the other packages, they don't have those. So we don't need to target any additional TFMs explicitely.
Unless I'm getting that wrong somehow.

@klemmchr
Copy link

klemmchr commented Sep 4, 2024

From my understanding this does not only apply to direct dependencies but also to downstream dependencies (see #2021 (comment)). This would affect all libraries that have a dependency on Sentry.AspNetCore too.

@bitsandfoxes
Copy link
Contributor Author

bitsandfoxes commented Sep 5, 2024

TIL! Fair enough. Created an issue to track this: #3598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants