Skip to content

Conversation

@vaind
Copy link
Collaborator

@vaind vaind commented Jan 11, 2024

#skip-changelog

While trying to make .NET8 device tests work, I've noticed we have some outdated test dependencies.
This makes the changes in a self-contained PR.

@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbf8fac) 76.39% compared to head (657ee62) 76.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
- Coverage   76.39%   76.38%   -0.02%     
==========================================
  Files         351      351              
  Lines       13257    13257              
  Branches     2645     2645              
==========================================
- Hits        10128    10126       -2     
- Misses       2450     2452       +2     
  Partials      679      679              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaind vaind marked this pull request as ready for review January 12, 2024 08:17

<ItemGroup Condition="'$(TargetFramework)' != 'net48'">
<PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0" />
Copy link
Contributor

@bitsandfoxes bitsandfoxes Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's a proper bump.

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vaind vaind merged commit a275292 into main Jan 12, 2024
@vaind vaind deleted the chore/dependencies-updates branch January 12, 2024 11:06
vaind added a commit that referenced this pull request Jan 12, 2024
* update internal dependencies

* roll back verify.xunit

* roll back xunit.runner.visualstudio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants