feat: appdomain exit flush - #242
Merged
bruno-garcia merged 6 commits intoJul 24, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 89.28% 89.28% -0.01%
==========================================
Files 81 82 +1
Lines 2035 2053 +18
==========================================
+ Hits 1817 1833 +16
- Misses 218 220 +2
Continue to review full report at Codecov.
|
bruno-garcia
requested changes
Jul 18, 2019
bruno-garcia
left a comment
bruno-garcia
left a comment
Member
There was a problem hiding this comment.
Great stuff as always. Thanks again1
bruno-garcia
requested changes
Jul 18, 2019
added 3 commits
July 23, 2019 12:21
…ntegration extension method
…just call Dispose instead of FlushAsync
Member
|
@josh-degraw code LGTM but build is unhappy. |
Contributor
Author
|
@bruno-garcia 🤦♂ I forgot to update the tests after refactoring and it didn't warn me locally because the test project was unloaded. I'll fix that and update asap. |
bruno-garcia
approved these changes
Jul 24, 2019
Member
|
Thanks @josh-degraw ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: #232