feat(apple): MetricKit GA #8186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove experimental note and add some info on MetricKit events.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7 tasks
kahest
approved these changes
Oct 12, 2023
Contributor
kahest
left a comment
kahest
left a comment
There was a problem hiding this comment.
🚀 thanks Philipp!
left small wording suggestions
Co-authored-by: Karl Heinz Struggl <[email protected]>
Co-authored-by: Karl Heinz Struggl <[email protected]>
lizokm
approved these changes
Oct 12, 2023
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Left a few language suggestions. Also, would it be possible to change the title of this section from "Metric Kit" to "MetricKit" to match how it's written in the world? :)
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
shanamatthews
approved these changes
Oct 13, 2023
Contributor
shanamatthews
left a comment
shanamatthews
left a comment
There was a problem hiding this comment.
Just one spelling fix. LGTM!
Co-authored-by: Shana Matthews <[email protected]>
Member
Author
|
Thanks for merging this, @kahest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Remove experimental note and add some info on MetricKit events.
Only merge this PR after releasing Cocoa 8.14.0.