feat(apple): Add docs for pre-warmed app starts #5762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add docs for the experimental feature enablePreWarmedAppStartTracking, which will be released with getsentry/sentry-cocoa#1969.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
lizokm
reviewed
Nov 13, 2022
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Hi Philip! I've suggested some changes that would make this doc flow better. There is one part that I'm not sure I'm understanding correctly. We can make updates if my interpretation is incorrect.
@imatwawana would love your eyes on this one too!
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
…ic-instrumentation.mdx Co-authored-by: Liza Mock <[email protected]>
…ic-instrumentation.mdx Co-authored-by: Liza Mock <[email protected]>
…ic-instrumentation.mdx Co-authored-by: Liza Mock <[email protected]>
…ic-instrumentation.mdx Co-authored-by: Liza Mock <[email protected]>
imatwawana
approved these changes
Nov 15, 2022
Contributor
imatwawana
left a comment
imatwawana
left a comment
There was a problem hiding this comment.
I made a few small wording and style tweaks, but otherwise LGTM!
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/apple/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
…ic-instrumentation.mdx Co-authored-by: Isabel <[email protected]>
…ic-instrumentation.mdx Co-authored-by: Isabel <[email protected]>
…ic-instrumentation.mdx Co-authored-by: Isabel <[email protected]>
…ic-instrumentation.mdx Co-authored-by: Isabel <[email protected]>
…ic-instrumentation.mdx Co-authored-by: Isabel <[email protected]>
Member
Author
|
Thank you, @imatwawana, for the style tweaks 😀. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs for the experimental feature enablePreWarmedAppStartTracking, which will be released with
getsentry/sentry-cocoa#1969.
Only merge after releasing getsentry/sentry-cocoa#1969.