Skip to content

Conversation

@PeloWriter
Copy link
Contributor

@PeloWriter PeloWriter commented Apr 27, 2021

Adding initial content to cover the Symfony tracing after a brief convo with @HazAT. Related to #3463,

Fixes #3463

@PeloWriter PeloWriter requested a review from rhcarvalho as a code owner April 27, 2021 01:05
@vercel
Copy link

vercel bot commented Apr 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/HhRVsYAo4m9WAHggKjaZo9cBZ5HQ
✅ Preview: https://sentry-docs-git-update-symfony-php-performance-integrations.sentry.dev

@PeloWriter PeloWriter marked this pull request as draft April 27, 2021 01:05
@PeloWriter PeloWriter requested a review from HazAT April 27, 2021 01:06
@HazAT HazAT marked this pull request as ready for review April 27, 2021 06:21
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one common misconception: tracing is enabled by default.

Apart from that, I find the current structure of the guide for Symfony confusing: there's Config and Configuration sections, there's constant cross-reference to content related to the generic PHP SDK, there's no line between what's responsibility of the Symfony bundle and what belongs to the base SDK...

@PeloWriter
Copy link
Contributor Author

I'm checking this file, and see that enabled is set to false, which is why the content says it is disabled by default.

The structure issue requires a larger investigation, thanks for raising it.

@ste93cry
Copy link
Contributor

I'm checking this file, and see that enabled is set to false, which is why the content says it is disabled by default.

Sorry, that's just a fixture file used for the tests. As soon as the conditions for each integration to be enabled are satisfied the integration is automatically enabled

@PeloWriter
Copy link
Contributor Author

Got it. Thanks for clarifying. I'll modify appropriately.

@PeloWriter
Copy link
Contributor Author

I've also added an issue to track the need to unknot the confusion between Symfony and PHP.

@PeloWriter
Copy link
Contributor Author

@ste93cry - can you please review with the updated samples? Many thanks.

Copy link
Contributor Author

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I've updated to:

"E_ALL defaults to the value returned by the error_reporting() function, which can change at runtime. Alternately, you can set the option to a fixed value by setting error_types to a different constant in \Sentry\init(). In this case, Sentry will log errors of that specific type regardless of the current reporting level."

@ste93cry
Copy link
Contributor

It's still wrong. Here the corrected version:

By default, the error_types option defaults to the value returned by the error_reporting() function, which can change at runtime. Alternately, you can set the option to a fixed value by setting its value to a bitmask of the PHP E_* constants in \Sentry\init(). In this case, Sentry will log only errors of those specific types regardless of the current reporting level.

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough to merge for now.

@PeloWriter PeloWriter merged commit 5268a34 into master May 3, 2021
@PeloWriter PeloWriter deleted the update/symfony-php-performance-integrations branch May 3, 2021 17:24
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation about tracing

5 participants