-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Initial content for Symfony performance integrations #3470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial content for Symfony performance integrations #3470
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/HhRVsYAo4m9WAHggKjaZo9cBZ5HQ |
Jean85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one common misconception: tracing is enabled by default.
Apart from that, I find the current structure of the guide for Symfony confusing: there's Config and Configuration sections, there's constant cross-reference to content related to the generic PHP SDK, there's no line between what's responsibility of the Symfony bundle and what belongs to the base SDK...
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
|
I'm checking this file, and see that The structure issue requires a larger investigation, thanks for raising it. |
Sorry, that's just a fixture file used for the tests. As soon as the conditions for each integration to be enabled are satisfied the integration is automatically enabled |
|
Got it. Thanks for clarifying. I'll modify appropriately. |
|
I've also added an issue to track the need to unknot the confusion between Symfony and PHP. |
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
|
@ste93cry - can you please review with the updated samples? Many thanks. |
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefano Arlandini <[email protected]>
Co-authored-by: Stefano Arlandini <[email protected]>
PeloWriter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I've updated to:
"E_ALL defaults to the value returned by the error_reporting() function, which can change at runtime. Alternately, you can set the option to a fixed value by setting error_types to a different constant in \Sentry\init(). In this case, Sentry will log errors of that specific type regardless of the current reporting level."
|
It's still wrong. Here the corrected version:
|
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
src/platforms/php/guides/symfony/performance/pm-integrations.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alessandro Lai <[email protected]>
Co-authored-by: Alessandro Lai <[email protected]>
Co-authored-by: Alessandro Lai <[email protected]>
HazAT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough to merge for now.
Adding initial content to cover the Symfony tracing after a brief convo with @HazAT. Related to #3463,
Fixes #3463