-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(nextjs): Add vercel specific microfrontends guide #15520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 341.55kB (1.47%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
inventarSarah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋
I haven't reviewed everything yet, but I have a question about the scope of the guide that I need answered before continuing (see my comment).
Thanks!
docs/platforms/javascript/guides/nextjs/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,39 @@ | |||
| --- | |||
| title: Micro Frontends | |||
| description: "Learn how to add Sentry instrumentation to your Vercel's micro frontend projects." | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this guide only for Vercel? If so, do we need the detailed content on module federation. As I understand it, Vercel only supports mult-zone apps - please lmk :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I tried setting one up and it worked, although they don't document it:
https://github.com/vercel-labs/microfrontends-single-spa-module-federation/
It's not in their docs or listed anywhere except their GitHub, so what do you think we should do here?
Co-authored-by: Sarah Mischinger <[email protected]>
Adds micro frontends guide specific to vercel's microfrontends feature since it has multi-zone application support which doesn't require the use of module federation.