ref(develop/spans): Expand ignoreSpans type and implementation specification
#14571
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
changed the title
ignoreSpans type and implementation specificationignoreSpans type and implementation specification
cleptric
left a comment
cleptric
left a comment
There was a problem hiding this comment.
We won't have an op once we move to span streaming.
I'm ok to not document this for now as it's JS only. We can keep the remaining changes though.
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Adds documentation for the new `ignoreSpans` option to be released with SDK version 10.2.0. SDK PR: getsentry/sentry-javascript#16820 Develop Docs spec change: #14571 closes #14569 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: Alex Krawiec <[email protected]>
Lms24
force-pushed
the
lms/ref-develop-ignorespans
branch
from
89721bf to
890aba7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | { | ||
| name?: IgnoreSpanNamePattern; | ||
| attributes?: Record<string, EnhancedAttributeValueTypes>; | ||
| } |
There was a problem hiding this comment.
Bug: Empty Filter Configurations Allowed
The IgnoreSpanFilter union type allows empty objects {} because its second variant makes both name and attributes optional. This creates meaningless filter configurations that lack any criteria, potentially confusing SDK implementers and users. At least one of name or attributes should be required for a valid filter.
|
@cleptric @mydea I rewrote the filter object to have For JS, we can transition over to attributes and continue supporting |
DESCRIBE YOUR PR
Develop Docs PR that expands the specification for
ignoreSpans:nameandopcloses #14568
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES