Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Laravel docs #1380

Merged
merged 5 commits into from
Dec 17, 2019
Merged

Update Laravel docs #1380

merged 5 commits into from
Dec 17, 2019

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Nov 29, 2019

This updates a few things in the Laravel documentation:

/cc @HazAT (& @Jean85 & @ste93cry for textual / PHP SDK bits)

@stayallive stayallive marked this pull request as ready for review November 29, 2019 09:10
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I can understand of Laravel, this LGTM 👍

@HazAT
Copy link
Member

HazAT commented Dec 17, 2019

@stayallive is this the file you were looking for?
https://github.com/getsentry/sentry-docs/blob/master/src/collections/_documentation/enriching-error-data/user-feedback-example/laravel.md
src/collections/_documentation/enriching-error-data/user-feedback-example/laravel.md

@stayallive
Copy link
Collaborator Author

@HazAT yeah it was! Also I needed to restart bin/server each time for changes to show 😄

If you could take a pass to see if there aren't any weird sentences in it that would be appreciated. But I think this is ready to 🚢 now.

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good work!

@HazAT HazAT merged commit b795904 into getsentry:master Dec 17, 2019
@stayallive stayallive deleted the laravel-updates branch December 17, 2019 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants