Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve docs of send-default-pii #1242

Merged
merged 3 commits into from
Oct 1, 2019

Conversation

untitaker
Copy link
Member

Fix #1240

@faassen
Copy link

faassen commented Sep 30, 2019

I suggest linking to the section https://docs.sentry.io/data-management/sensitive-data/#custom-event-processing-in-the-sdk directly, as that's really the mechanism the user would need to employ to hook into the scrubbing process in the SDK itself. I would also recommend naming 'before-send' directly within the docs for send-default-pii, as that sets users directly on the right path.

@untitaker
Copy link
Member Author

@faassen so depending on what your privacy policy contains, it may be entirely permissible to scrub data on the serverside only, which is easier to set up

@untitaker
Copy link
Member Author

@faassen I believe this structure makes sense.. "Sensitive Data" contains all links now, and you can discover that page from send-default-pii.

Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@untitaker untitaker merged commit e5a01f6 into master Oct 1, 2019
@untitaker untitaker deleted the fix/send-default-pii-language branch October 1, 2019 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send_default_pii: what do the docs really recommend?
4 participants