-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP: do not merge] add Sampling section to Quotas & Filtering #1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
So the main thing here is this isnt just a documentation change I want to make. I want us to reframe how we think about "managing data you send to sentry". Sampling is the answer folks need to rely on. The rate limits and expectation of rate limits have been super abusive to the point where we're considering drastically reducing their effectiveness. I would rather the whole section be about Sampling as thats a core theme of Sentry going forward (and is why we added sampleRate). With that in said, I dont think its appropriate just to copy/paste the section in. The framing of the paragraphs makes less sense when they're a subsection of the page and more sense when its "this is why you might not need or want all of your data" |
Okay. I can put together a plan on how to restructure the whole thing so that Sampling takes precedence. |
|
||
In some situations, you may want to sample data within Sentry. Sampling is a valuable tool if you're concerned about the cost of Sentry, or if some data is naturally very high volume and noisy (like [_Security Policy Reports_]({%- link _documentation/error-reporting/security-policy-reporting.md -%})). | ||
|
||
All of Sentry's SDKs provide a `sampleRate` configuration. For example, in JavaScript: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of Sentry's SDKs provide a
sampleRate
configuration.
I believe this is true of all unified SDK's. Is it true of all the legacy ones as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe almost every SDK has some type of sampling but not 100% sure. For example, raven-JS has sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but it's "spelled" differently in some of the legacy SDK's, I believe. Worth checking to know for sure.
@dcramer, Katie and I will tackle this next week. |
Conversations around sampling will increase as Sentry approaches APM launch. This section will help kickoff discussion and raise visibility of sampling.