Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP: do not merge] add Sampling section to Quotas & Filtering #1062

Closed
wants to merge 1 commit into from

Conversation

MimiDumpling
Copy link
Contributor

Conversations around sampling will increase as Sentry approaches APM launch. This section will help kickoff discussion and raise visibility of sampling.

@MimiDumpling MimiDumpling requested a review from dcramer June 12, 2019 00:24
@MimiDumpling
Copy link
Contributor Author

@dcramer talked with @LSSangha and we feel like this is a good place for Sampling. :) Let us know what you think.

Copy link
Contributor

@LSSangha LSSangha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dcramer
Copy link
Member

dcramer commented Jun 12, 2019

So the main thing here is this isnt just a documentation change I want to make. I want us to reframe how we think about "managing data you send to sentry". Sampling is the answer folks need to rely on. The rate limits and expectation of rate limits have been super abusive to the point where we're considering drastically reducing their effectiveness. I would rather the whole section be about Sampling as thats a core theme of Sentry going forward (and is why we added sampleRate).

With that in said, I dont think its appropriate just to copy/paste the section in. The framing of the paragraphs makes less sense when they're a subsection of the page and more sense when its "this is why you might not need or want all of your data"

@MimiDumpling
Copy link
Contributor Author

MimiDumpling commented Jun 12, 2019

So the main thing here is this isnt just a documentation change I want to make. I want us to reframe how we think about "managing data you send to sentry". Sampling is the answer folks need to rely on. The rate limits and expectation of rate limits have been super abusive to the point where we're considering drastically reducing their effectiveness. I would rather the whole section be about Sampling as thats a core theme of Sentry going forward (and is why we added sampleRate). The framing of the paragraphs makes less sense when they're a subsection of the page and more sense when its "this is why you might not need or want all of your data"

Okay. I can put together a plan on how to restructure the whole thing so that Sampling takes precedence.


In some situations, you may want to sample data within Sentry. Sampling is a valuable tool if you're concerned about the cost of Sentry, or if some data is naturally very high volume and noisy (like [_Security Policy Reports_]({%- link _documentation/error-reporting/security-policy-reporting.md -%})).

All of Sentry's SDKs provide a `sampleRate` configuration. For example, in JavaScript:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of Sentry's SDKs provide a sampleRate configuration.

I believe this is true of all unified SDK's. Is it true of all the legacy ones as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe almost every SDK has some type of sampling but not 100% sure. For example, raven-JS has sample.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but it's "spelled" differently in some of the legacy SDK's, I believe. Worth checking to know for sure.

@MimiDumpling
Copy link
Contributor Author

@dcramer, Katie and I will tackle this next week.

@MimiDumpling MimiDumpling changed the title add Sampling section to Quotas & Filtering [do not merge] add Sampling section to Quotas & Filtering Oct 31, 2019
@MimiDumpling MimiDumpling changed the title [do not merge] add Sampling section to Quotas & Filtering [WIP: do not merge] add Sampling section to Quotas & Filtering Oct 31, 2019
@joshuarli joshuarli deleted the update/mimi-quotas-filtering branch August 4, 2020 01:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants