Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clarification to controller location for Express #1049

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

twolfson
Copy link
Contributor

@twolfson twolfson commented Jun 7, 2019

While setting up a new project, I spent a very long and sad amount of time trying to figure out why Sentry wasn't receiving my errors that I was clearly seeing locally. It turns out I put the error handler too high up. In this PR:

  • Added clarification to controller location for Express

Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twolfson thanks for the contribution! 👍

@dashed dashed merged commit 57cb8b1 into getsentry:master Jun 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants