Grey out unsupported options #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
reviewed
Jun 6, 2019
|
|
||
| {:.config-key} | ||
| ### `https-proxy` | ||
|
|
||
| {% unsupported csharp aspnetcore php %} | ||
| {% unsupported browser csharp aspnetcore php %} |
There was a problem hiding this comment.
Given these, you might check w the SDK folks if those SDK's should also be on http-proxy, or if those other ones support http but not https.
There was a problem hiding this comment.
this note is more for me, but confirmed that csharp and aspnetcore don't need to change, awaiting confirmation about php
There was a problem hiding this comment.
also confirmed w/ PHP that this doesn't need to change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
New:
