Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): Update development setup instructions #1037

Merged
merged 3 commits into from
Jun 7, 2019
Merged

fix(dev): Update development setup instructions #1037

merged 3 commits into from
Jun 7, 2019

Conversation

dashed
Copy link
Member

@dashed dashed commented May 31, 2019 •
edited
Loading

Adapt development setup instructions to Makefile changes introduced in getsentry/sentry#12620 and getsentry/sentry#13518

I had some issues setting up sentry with just make develop.

@dashed dashed requested review from wedamija and lauryndbrown May 31, 2019 01:44
@dashed
Copy link
Member Author

dashed commented May 31, 2019

It seems like these are the sequence of commands to setup sentry on macOS:

make install-system-pkgs
make develop
sentry init --dev
sentry devservices up
make create-db 
make apply-migrations

I'll amend the PR with these additions.

@dashed dashed mentioned this pull request Jun 4, 2019
Merged
@dashed dashed added the wip label Jun 4, 2019
@dashed dashed force-pushed the update-dev-setup-instructions branch from 999db42 to 65c2950 Compare June 6, 2019 19:39
@dashed dashed requested a review from MimiDumpling June 6, 2019 19:40
@dashed dashed removed the wip label Jun 6, 2019
@dashed
Copy link
Member Author

dashed commented Jun 6, 2019

I've amended the dev setup documentation to include instructions introduced in getsentry/sentry#13518

@MimiDumpling I'm adding you as a potential reviewer in case you have any thoughts on these changes.

MimiDumpling
MimiDumpling reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for updating the doc! 👍

@dashed dashed merged commit e12da54 into master Jun 7, 2019
@dashed dashed deleted the update-dev-setup-instructions branch June 7, 2019 16:26
@dashed dashed mentioned this pull request Jun 10, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MimiDumpling MimiDumpling MimiDumpling left review comments

@markstory markstory markstory approved these changes

@wedamija wedamija Awaiting requested review from wedamija

@lauryndbrown lauryndbrown Awaiting requested review from lauryndbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dashed @markstory @MimiDumpling